|
Pages: 1 [2]
|
 |
|
Author
|
Topic: Patch to find a star system quickly (Read 8577 times)
|
|
|
Novus
Enlightened
 Offline
Gender: 
Posts: 1938
Fot or not?
|
I like this patch. I would like it even more if I could enter the full name of a star in a cluster (e.g. "Alpha Centauri") and select only that star. Right now, searching for "Centauri" works, but searching for "Alpha Centauri" fails silently (the selection isn't changed at all).
I'd also change the default key mapping to a key that actually exists on my keyboard; many European keyboards don't have a "/" key!
|
|
|
|
|
Logged
|
|
|
|
|
|
Torch
Zebranky food
Offline
Posts: 23
|
UQM-fsmod.rar is broken ('Unexpected end of archive'). Please make new archive.
|
|
|
|
|
Logged
|
|
|
|
Novus
Enlightened
Offline
Gender:
Posts: 1938
Fot or not?
|
Try this instead. I've applied the starmap search and ship spin video patches.
The usual disclaimer, of course, applies. If you break something, you get to keep the pieces.
|
|
|
|
|
Logged
|
|
|
|
Megagun
Enlightened
Offline
Gender:
Posts: 580
Moo
|
Rargh. Blame my internet for failing when I reuploaded it (forgot to mention the name of the creator of it).. Reuploading....
|
|
|
|
|
Logged
|
|
|
|
|
|
|
|
Novus
Enlightened
Offline
Gender:
Posts: 1938
Fot or not?
|
Just updated to v2 of your patch. Using MinGW under XP I get some really nasty graphics corruption after a while. Star names being printed over the map, the entire starmap turning blue, menus and stuff disappearing and so on. Also, the search feature sometimes seems to fail to find stars.
Seems like you have a synchronisation problem somewhere in there; probably lack of locking in the graphics code.
|
|
|
|
|
Logged
|
|
|
|
|
|
|
|
kworces
Zebranky food
Offline
Gender:
Posts: 9
jumping *peppers*!!
|
I only get these problems sporadically, and I didn't test v1 quite as thoroughly as v2. I reversed the v1 patch before applying v2, and the end result seems to be correct. Besides, it works most of the time, which I'd hardly expect from a badly applied patch.
Yeah, looks like DrawSISMessage needs to be proteced by GraphicsLock, which it was not where I was calling it. So I added the lock for those calls (v3, now available).
As for the search failing... I've searched for a few dozen star systems, multiple stars within those systems, stars that don't have peer stars (procyon, organon) with and without using prefixes. The search has always worked for me. To track down any search failures I'll need a repeatable example.
I'm fully willing to admit my code is not be bug-free, but I need to know more specifically what is wrong before I can fix it.
|
|
|
|
|
Logged
|
|
|
|
|
|
Novus
Enlightened
Offline
Gender:
Posts: 1938
Fot or not?
|
Version 3 of the patch is looking good. No bugs detected so far. I'll try it on a few different operating systems just to make sure.
|
|
|
|
|
Logged
|
|
|
|
fossil
Core Team
Frungy champion
Offline
Gender:
Posts: 94
|
A mostly modified version of this patch in now in CVS. It works somewhat differently and is folded into the new DoTextEntry().
The major difference is that you do not hit Enter before you start Tabbing through the matches and the text edit box is more in line with the rest of the GUI. Also the Menu-Tab key is called Menu-Next.
Enjoy, and thanks to kworces for the original!
|
|
|
|
|
Logged
|
|
|
|
|
Pages: 1 [2]
|
|
|
|
|
